fix: bundle daemon sidecars in app build#506
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad44bf9cd2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
package.json
Outdated
| "prebuild": "npm run sync:material-icons", | ||
| "build": "tsc && vite build", | ||
| "build:appimage": "NO_STRIP=1 tauri build --bundles appimage", | ||
| "build:tauri-sidecars": "sh scripts/build-tauri-sidecars.sh", |
There was a problem hiding this comment.
The new build:tauri-sidecars script invokes sh scripts/build-tauri-sidecars.sh, but build-tauri-sidecars.sh is written for Bash (set -euo pipefail, arrays, [[ ... ]], BASH_SOURCE). On systems where /bin/sh is not Bash (e.g. Ubuntu dash), this command fails immediately (set: Illegal option -o pipefail), so the sidecar build entrypoint added in this commit is unusable and cannot prepare binaries when called directly.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in e27036e. I replaced the shell-only sidecar step with a cross-platform Node script (scripts/build-tauri-sidecars.mjs) and updated both build:tauri-sidecars and beforeBuildCommand to use it, so this no longer depends on Bash or ./...sh on Windows.
|
Docs update pushed in d66dc60:
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d66dc603be
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7983ecea63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| const cargoArgs = ["build", "--release"]; | ||
| if (explicitTarget) { | ||
| cargoArgs.push("--target", buildTarget); |
There was a problem hiding this comment.
tauri build --help allows universal-apple-darwin, but this hook forwards TAURI_ENV_TARGET_TRIPLE directly to cargo build --target. When the build target is universal, Cargo rejects it (could not find specification for target "universal-apple-darwin"), so beforeBuildCommand fails before Tauri can do its universal macOS build flow. This makes supported universal macOS builds fail whenever sidecar prep runs.
Useful? React with 👍 / 👎.
2 participants
Summary
codex_monitor_daemonandcodex_monitor_daemonctlviabundle.externalBinscripts/build-tauri-sidecars.shto build and stage sidecar binaries before Tauri bundlingbeforeBuildCommandsrc-tauri/binaries/Notes
codex_monitor_daemonctl